- 24 Jan, 2022 7 commits
-
-
Cy Schubert authored
I still didn't sort it right. Pointy hat to: cy
-
Cy Schubert authored
Sort unbound entry by date.
-
Cy Schubert authored
As of unbound 1.14.0rc1, as per RFC8375 unbound by default blocks 'home.arpa'. Document this new behaviour and how to unblock it. Reported by: avg Discussed with: glebius, avg RFC: 8375, Section 6: Security Considerations
-
Cy Schubert authored
Vendor import GA release of unbound 1.14.0. MFC after: 2 weeks Merge commit '9b87431a' into unbound/main
-
Kevin Lo authored
This fixes the standalone build.
-
Eugene Grosbein authored
MFC after: 1 month
-
Eugene Grosbein authored
Let "fetch -a" resume truncated transfer automatically perform another attempt if it obtained some new data in previous one making progress. This makes it more robust against frequent but transient network failures. For example: => sqlite-src-3370200.zip doesn't seem to exist in /usr/ports/distfiles/. => Attempting to fetch https://www.sqlite.org/2022/sqlite-src-3370200.zip sqlite-src-3370200.zip 3% of 12 MB 45 kBps 04m24s fetch: sqlite-src-3370200.zip appears to be truncated: 524288/13145234 bytes sqlite-src-3370200.zip 10% of 12 MB 67 kBps 02m56s fetch: sqlite-src-3370200.zip appears to be truncated: 1327104/13145234 bytes sqlite-src-3370200.zip 28% of 12 MB 123 kBps 01m14s fetch: sqlite-src-3370200.zip appears to be truncated: 3735552/13145234 bytes sqlite-src-3370200.zip 54% of 12 MB 253 kBps 24s fetch: sqlite-src-3370200.zip appears to be truncated: 7176192/13145234 bytes sqlite-src-3370200.zip 62% of 12 MB 90 kBps 55s fetch: sqlite-src-3370200.zip appears to be truncated: 8241152/13145234 bytes sqlite-src-3370200.zip 82% of 12 MB 113 kBps 20s fetch: sqlite-src-3370200.zip appears to be truncated: 10862592/13145234 bytes sqlite-src-3370200.zip 12 MB 185 kBps 12s ===> Fetching all distfiles required by sqlite3-3.37.2,1 for building MFC after: 1 month
-
- 23 Jan, 2022 10 commits
-
-
Rick Macklem authored
PR#254282 reports a problem where nullfs mounts cannot be exported via mountd for FreeBSD 13.0. The problem seems to be that, to do the nullfs mounts in /etc/fstab, they require the "late" mount option, so that the underlying filesystem is mounted (ZFS for the PR). Adding "mountlate" to the REQUIRE list in /etc/rc.d/mountd fixes the problem, but that results in a dependency cycle because /etc/rc.d/lockd specifies: REQUIRE: nfsd BEFORE: DAEMON --> which forces mountd to preceed DAEMON. This patch removes "nfsd" from REQUIRE for lockd and statd, then adds mountlate to REQUIRE for mountd, to fix this problem. Having lockd REQUIRE nfsd was done in the NetBSD code when it was pulled into FreeBSD and there does not seem to be a need for this. In case this causes problems, a long MFC has been specified. PR: 254282 Differential Revision: https://reviews.freebsd.org/D33256 MFC after: 3 months
-
Philippe Michaud-Boudreault authored
MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D30333
-
Michal Krawczyk authored
Some of the changes in this release: - IPv6 L4 checksum offload fixes. - Optimization of the Tx req_id validation. - Timer service adjustments. - NUMA awareness for the kernel RSS mode. Submitted by: Michal Krawczyk <mk@semihalf.com> Obtained from: Semihalf MFC after: 2 weeks Sponsored by: Amazon, Inc.
-
Michal Krawczyk authored
Verified spelling in the README and fixed the typos. Also updated the contact section by removing Artur and adding Dawid Gorecki who is now the second ENA FreeBSD driver developer. Submitted by: Michal Krawczyk <mk@semihalf.com> Obtained from: Semihalf MFC after: 2 weeks Sponsored by: Amazon, Inc.
-
Dawid Gorecki authored
If the device becomes unresponsive, the driver will not be able to finish the reset process correctly. Timeout during version validation indicates that the device is currently not responding. In that case do not perform the reset and instead reschedule timer service. Because of that the driver will continue trying to reset the device until it succeeds or is detached. Submitted by: Dawid Gorecki <dgr@semihalf.com> Obtained from: Semihalf MFC after: 2 weeks Sponsored by: Amazon, Inc.
-
Dawid Gorecki authored
The timer service was started when the interface was brought up and it was stopped when it was brought down. Since ena_up requires the device to be responsive, triggering the reset would become impossible if the device became unresponsive with the interface down. Since most of the functions in timer service already perform the check to see if the device is running, this only requires starting the callout in attach and stopping it when bringing the interface up or down to avoid race between different admin queue calls. Since callout functions for timer service are always called with the same arguments, replace callout_{init,reset,drain} calls with ENA_TIMER_{INIT,RESET,DRAIN} macros. Submitted by: Dawid Gorecki <dgr@semihalf.com> Obtained from: Semihalf MFC after: 2 weeks Sponsored by: Amazon, Inc.
-
Artur Rojek authored
Since `ena_com_tx_comp_req_id_get` already checks for `req_id` validity, the logic was exiting early, never giving `validate_tx_req_id` a chance to trigger device reset. Rewrite the logic so that device reset is called based on return value of `ena_com_tx_comp_req_id_get` instead. Submitted by: Artur Rojek <ar@semihalf.com> Obtained from: Semihalf MFC after: 2 weeks Sponsored by: Amazon, Inc.
-
Dawid Gorecki authored
ena_tx_csum function did not check if IPv6 checksum offload was requested it only checked checksum offloading flags for IPv4 packets. Because of that, when encountering CSUM_IP6_* flags, the function simply returned without actually setting checksum offloading in ena_ctx. Check CUSM_IP6_* flags to enable IPv6 checksum offload. Additionally, only IPv4 header was being parsed regardless of EtherType field, because of that, value of L4 protocol read when actually trying to send IPv6 packets was wrong. Use ip6_lasthdr function to get length of all IPv6 headers and payload protocol. Set the DF flag to 1 in order to allow the device to offload the IPv6 checksum calculation and achieve optimal performance. Add CSUM6_OFFLOAD and CSUM_OFFLOAD definitions into ena_datapath.h. Submitted by: Dawid Gorecki <dgr@semihalf.com> Obtained from: Semihalf MFC after: 2 weeks Sponsored by: Amazon, Inc.
-
Marcin Wojtas authored
Merge commit '2530eb1f' Adjust the driver to the upgraded ena-com part twofold: First update is related to the driver's NUMA awareness. Allocate I/O queue memory in NUMA domain local to the CPU bound to the given queue, improving data access time. Since this can result in performance hit for unaware users, this is done only when RSS option is enabled, for other cases the driver relies on kernel to allocate memory by itself. Information about first CPU bound is saved in adapter structure, so the binding persists after bringing the interface down and up again. If there are more buckets than interface queues, the driver will try to bind different interfaces to different CPUs using round-robin algorithm (but it will not bind queues to CPUs which do not have any RSS buckets associated with them). This is done to better utilize hardware resources by spreading the load. Add (read-only) per-queue sysctls in order to provide the following information: - queueN.domain: NUMA domain associated with the queue - queueN.cpu: CPU affinity of the queue The second change is for the CSUM_OFFLOAD constant, as ENA platform file has removed its definition. To align to that change, it has been added to the ena_datapath.h file. Submitted by: Artur Rojek <ar@semihalf.com> Submitted by: Dawid Gorecki <dgr@semihalf.com> Obtained from: Semihalf MFC after: 2 weeks Sponsored by: Amazon, Inc.
-
Martin Matuska authored
Add missing source file lz4_zfs.c to sys/conf/files
-
- 22 Jan, 2022 13 commits
-
-
Martin Matuska authored
Notable upstream pull request merges: #12766 Fix error propagation from lzc_send_redacted #12805 Updated the lz4 decompressor #12851 FreeBSD: Provide correct file generation number #12857 Verify dRAID empty sectors #12874 FreeBSD: Update argument types for VOP_READDIR #12896 Reduce number of arc_prune threads #12934 FreeBSD: Fix zvol_*_open() locking #12947 lz4: Cherrypick fix for CVE-2021-3520 #12961 FreeBSD: Fix leaked strings in libspl mnttab #12964 Fix handling of errors from dmu_write_uio_dbuf() on FreeBSD #12981 Introduce a flag to skip comparing the local mac when raw sending #12985 Avoid memory allocations in the ARC eviction thread Obtained from: OpenZFS OpenZFS commit: 17b2ae0b
-
Dimitry Andric authored
No functional change intended. MFC after: 3 days
-
Dimitry Andric authored
* Use "yyyymmdd: description" format * Remove dots at EOL MFC after: 3 days
-
Michał Górny authored
Disable the gdb packet run length encoding for 3-symbol repetitions. While it is technically possible to encode them, they have no advantage over sending the characters verbatim (the resulting length is the same) and they result in sending non-printable \x1f character. The protocol has been designed with the intent of avoiding non-printable characters and therefore the run length encoding is biased to emit \x20 (a space) with the minimal intended run length of 4. While at it, simplify the logic by merging the different 'if' blocks into a single while loop, and moving 'runlen == 0' check lower. Reviewed by: cem, emaste MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D33686
-
Ed Maste authored
The text after .error et al is emitted verbatim. Reviewed by: sjg Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D33904
-
Ed Maste authored
%p already includes the 0x. Sponsored by: The FreeBSD Foundation
-
Konstantin Belousov authored
Reviewed by: emaste Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D33986
-
Konstantin Belousov authored
that disables any access to ptrace(2) for all processes. Reviewed by: emaste Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D33986
-
Konstantin Belousov authored
Privilege checks in both functions should allow the current process to infer information about itself, as well as use the interfaces that are proclaimed 'debugging', for instance, procctl(2). Note that in p_cansee() case, explicit comparision of curproc and p avoids a race where the process might change credentials and cause thread to compare its cached stale credentials against updated process creds, effectively disallowing the process to observe itself. Reviewed by: emaste Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D33986
-
Konstantin Belousov authored
For non-anonymous swap objects, there is always a reference from the owner to the object to keep it from recycling. Account for it when deciding should we query pmap for hardware active references for the page. As result, we avoid unneeded calls to pmap_ts_referenced(), which for non-mapped page means avoiding unneccessary lock and unlock of the pv list. Reviewed by: markj Discussed with: alc Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D33924
-
Wojciech Macek authored
Add missing unlock if V_ip_mrotue is not set Obtained from: Semihalf
-
Stefan Eßer authored
An enhanced version of this script has been committed to the ports repository as /usr/ports/Tools/scripts/port_conflicts_check.lua.
-
Wojciech Macek authored
Add mising "else" branch to release a lock if mrouter is not configured. Obtained from: Semihalf Sponsored by: Stormshield
-
- 21 Jan, 2022 10 commits
-
-
наб authored
CLOCK_MONOTONIC_RAW is only a thing on Linux and macOS. I'm not actually sure why the previous hardcoding of a constant didn't error out, but when we removed it, it sure does now. Reviewed-by:
Alexander Motin <mav@FreeBSD.org> Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Co-authored-by:
Rich Ercolani <rincebrain@gmail.com> Signed-off-by:
Rich Ercolani <rincebrain@gmail.com> Closes #12995
-
Ka Ho Ng authored
Sponsored by: The FreeBSD Foundation MFC after: 3 days
-
Mark Johnston authored
FreeBSD's implementation of zfs_uio_fault_move() returns EFAULT when a page fault occurs while copying data in or out of user buffers. The VFS treats such errors specially and will retry the I/O operation (which may have made some partial progress). When the FreeBSD and Linux implementations of zfs_write() were merged, the handling of errors from dmu_write_uio_dbuf() changed such that EFAULT is not handled as a partial write. For example, when appending to a file, the z_size field of the znode is not updated after a partial write resulting in EFAULT. Restore the old handling of errors from dmu_write_uio_dbuf() to fix this. This should have no impact on Linux, which has special handling for EFAULT already. Reviewed-by:
Andriy Gapon <avg@FreeBSD.org> Reviewed-by:
Ryan Moeller <ryan@iXsystems.com> Signed-off-by:
Mark Johnston <markj@FreeBSD.org> Closes #12964
-
George Amanakis authored
Raw receiving a snapshot back to the originating dataset is currently impossible because of user accounting being present in the originating dataset. One solution would be resetting user accounting when raw receiving on the receiving dataset. However, to recalculate it we would have to dirty all dnodes, which may not be preferable on big datasets. Instead, we rely on the os_phys flag OBJSET_FLAG_USERACCOUNTING_COMPLETE to indicate that user accounting is incomplete when raw receiving. Thus, on the next mount of the receiving dataset the local mac protecting user accounting is zeroed out. The flag is then cleared when user accounting of the raw received snapshot is calculated. Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
George Amanakis <gamanakis@gmail.com> Closes #12981 Closes #10523 Closes #11221 Closes #11294 Closes #12594 Issue #11300
-
Artur Rojek authored
Add implementation for the ENA_MEM_ALLOC_NODE and ENA_MEM_ALLOC_COHERENT_NODE_* macros. Also the signature of ena_dma_alloc() function was updated, for which the implementation will be updated in ENA driver's patch. Submitted by: Artur Rojek <ar@semihalf.com> Submitted by: Dawid Gorecki <dgr@semihalf.com> Submitted by: Michal Krawczyk <mk@semihalf.com> Obtained from: Semihalf Sponsored by: Amazon, Inc.
-
Michal Krawczyk authored
CSUM_OFFLOAD is a constant which is used only by the core driver code. Because of that it shouldn't be defined in the platform file, as it's not the platform specific code which is used only by the ena_com layer. Submitted by: Dawid Gorecki <dgr@semihalf.com> Submitted by: Michal Krawczyk <mk@semihalf.com> Obtained from: Semihalf Sponsored by: Amazon, Inc.
-
John Baldwin authored
GCC6 raises a -Wredundant-decl error due to duplicate declarations in ena_fbsd_log.h and ena_plat.h. Sponsored by: Chelsio Communications
-
Mark Johnston authored
When the eviction thread goes to shrink an ARC state, it allocates a set of marker buffers used to hold its place in the state's sublists. This can be problematic in low memory conditions, since 1) the allocation can be substantial, as we allocate NCPU markers; 2) on at least FreeBSD, page reclamation can block in arc_wait_for_eviction() In particular, in stress tests it's possible to hit a deadlock on FreeBSD when the number of free pages is very low, wherein the system is waiting for the page daemon to reclaim memory, the page daemon is waiting for the ARC eviction thread to finish, and the ARC eviction thread is blocked waiting for more memory. Try to reduce the likelihood of such deadlocks by pre-allocating markers for the eviction thread at ARC initialization time. When evicting buffers from an ARC state, check to see if the current thread is the ARC eviction thread, and use the pre-allocated markers for that purpose rather than dynamically allocating them. Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by:
Alexander Motin <mav@FreeBSD.org> Reviewed-by:
George Amanakis <gamanakis@gmail.com> Signed-off-by:
Mark Johnston <markj@FreeBSD.org> Closes #12985
-
наб authored
sizeof(bitfield.member) is invalid, and this shows up in some FreeBSD build configurations: work around this by !!ing ‒ this makes the sizeof target the ! result type (_Bool), instead Reviewed-by:
Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by:
Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Fixes: 42aaf0e7 ("libspl: ASSERT*: mark arguments as used") Closes #12984 Closes #12986
-
Ryan Moeller authored
An AHCI controller may be specified with no connected ports. Avoid dumping core in this case for compatibility with existing VM configs. Reviewed by: khng, jhb Fixes: 621b5090 Refactor configuration management in bhyve. MFC after: 1 week Sponsored by: iXsystems, Inc. Differential Revision: https://reviews.freebsd.org/D33969
-