Skip to content

GitLab

Switch branch/tag
  1. 25 Jan, 2022 4 commits
  3. 24 Jan, 2022 28 commits
  5. 23 Jan, 2022 8 commits
    • HardenedBSD Sync Service's avatar
      Merge branch 'freebsd/current/main' into hardened/current/master · f7eeb076
      HardenedBSD Sync Service authored
      f7eeb076
    • Rick Macklem's avatar
      mountd: Delay starting mountd until after mountlate · f72926ea
      Rick Macklem authored 
      PR#254282 reports a problem where nullfs mounts cannot be
exported via mountd for FreeBSD 13.0.

The problem seems to be that, to do the nullfs mounts in
/etc/fstab, they require the "late" mount option, so that the
underlying filesystem is mounted (ZFS for the PR).

Adding "mountlate" to the REQUIRE list in /etc/rc.d/mountd
fixes the problem, but that results in a dependency cycle
because /etc/rc.d/lockd specifies:

REQUIRE: nfsd
BEFORE: DAEMON
--> which forces mountd to preceed DAEMON.

This patch removes "nfsd" from REQUIRE for lockd and statd,
then adds mountlate to REQUIRE for mountd, to fix this
problem.  Having lockd REQUIRE nfsd was done in the NetBSD
code when it was pulled into FreeBSD and there does not
seem to be a need for this.

In case this causes problems, a long MFC has been specified.

PR:	254282
Differential Revision:	https://reviews.freebsd.org/D33256
MFC after:	3 months
      f72926ea
    • Philippe Michaud-Boudreault's avatar
      sound: add patch for Lenovo Legion 5 AMD · 45f0e571
      Philippe Michaud-Boudreault authored 
      MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D30333
      45f0e571
    • Michal Krawczyk's avatar
      ena: update ENA version to v2.5.0 · 8a5b4859
      Michal Krawczyk authored 
      Some of the changes in this release:
- IPv6 L4 checksum offload fixes.
- Optimization of the Tx req_id validation.
- Timer service adjustments.
- NUMA awareness for the kernel RSS mode.

Submitted by: Michal Krawczyk <mk@semihalf.com>
Obtained from: Semihalf
MFC after: 2 weeks
Sponsored by: Amazon, Inc.
      8a5b4859
    • Michal Krawczyk's avatar
      ena: fix man page typos and update contact section · 95161adf
      Michal Krawczyk authored 
      Verified spelling in the README and fixed the typos.

Also updated the contact section by removing Artur and adding Dawid
Gorecki who is now the second ENA FreeBSD driver developer.

Submitted by: Michal Krawczyk <mk@semihalf.com>
Obtained from: Semihalf
MFC after: 2 weeks
Sponsored by: Amazon, Inc.
      95161adf
    • Dawid Gorecki's avatar
      ena: do not call reset if device is unresponsive · d10ec3ad
      Dawid Gorecki authored 
      If the device becomes unresponsive, the driver will not be able to
finish the reset process correctly. Timeout during version validation
indicates that the device is currently not responding. In that case
do not perform the reset and instead reschedule timer service. Because
of that the driver will continue trying to reset the device until it
succeeds or is detached.

Submitted by: Dawid Gorecki <dgr@semihalf.com>
Obtained from: Semihalf
MFC after: 2 weeks
Sponsored by: Amazon, Inc.
      d10ec3ad
    • Dawid Gorecki's avatar
      ena: start timer service on attach · 78554d0c
      Dawid Gorecki authored 
      The timer service was started when the interface was brought up and it
was stopped when it was brought down. Since ena_up requires the device
to be responsive, triggering the reset would become impossible if the
device became unresponsive with the interface down.

Since most of the functions in timer service already perform the check
to see if the device is running, this only requires starting the callout
in attach and stopping it when bringing the interface up or down to
avoid race between different admin queue calls.

Since callout functions for timer service are always called with the
same arguments, replace callout_{init,reset,drain} calls with
ENA_TIMER_{INIT,RESET,DRAIN} macros.

Submitted by: Dawid Gorecki <dgr@semihalf.com>
Obtained from: Semihalf
MFC after: 2 weeks
Sponsored by: Amazon, Inc.
      78554d0c
    • Artur Rojek's avatar
      ena: rework tx req_id validation logic · b168d0c8
      Artur Rojek authored 
      Since `ena_com_tx_comp_req_id_get` already checks for `req_id` validity,
the logic was exiting early, never giving `validate_tx_req_id` a chance
to trigger device reset.
Rewrite the logic so that device reset is called based on return value
of `ena_com_tx_comp_req_id_get` instead.

Submitted by: Artur Rojek <ar@semihalf.com>
Obtained from: Semihalf
MFC after: 2 weeks
Sponsored by: Amazon, Inc.
      b168d0c8