Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Menu
Open sidebar
Shawn Webb
Fwupd
Commits
dce91204
Commit
dce91204
authored
Apr 08, 2019
by
Richard Hughes
Browse files
Fix some typos spotted using codespell
parent
02ac92c1
Changes
37
Hide whitespace changes
Inline
Side-by-side
CONTRIBUTING.md
View file @
dce91204
...
...
@@ -18,7 +18,7 @@ from the PackageKit Coding Style.
*
Prefer descriptive names over abbreviations (unless well-known)
and shortening of names. e.g
`device`
not
`dev`
*
Single statments inside if/else should not be enclosed by '{}'
*
Single stat
e
ments inside if/else should not be enclosed by '{}'
*
Use comments to explain why something is being done, but also avoid
over-documenting the obvious. Here is an example of useless comment:
...
...
RELEASE
View file @
dce91204
...
...
@@ -29,7 +29,7 @@ git push
ninja dist
3a. Generate the additon verification metadata
3a. Generate the addit
i
on
al
verification metadata
gpg -b -a meson-dist/fwupd-${release_ver}.tar.xz
...
...
contrib/ci/README.md
View file @
dce91204
...
...
@@ -90,7 +90,7 @@ The XML is organized by a top level element representing the dependencies needed
The child elements represent individual dependencies for all distributions.
*
This element has an attribute
***id**
*
that represents the most common package name used by distributions
*
This element has an attribute
***type**
*
that reprsents if the package is needed at build time or runtime.
*
This element has an attribute
***type**
*
that repr
e
sents if the package is needed at build time or runtime.
Each dependency then has a mapping to individual distributions (___distro___).
*
This element has an attribute
***id**
*
that represents the distribution.
...
...
contrib/firmware-packager/README.md
View file @
dce91204
...
...
@@ -41,7 +41,7 @@ bin file inside the archive, I would pass `--exe dell-thunderbolt-firmware.exe -
`--developer-name`
Name of the firmware developer (e.g. Dell)
**REQUIRED**
`--release-version`
Version number of the firmware package (e.g. 4.21.01.002)
**REQUIRED**
`--release-description`
Description of the firmware release, again this can theoretically include HTML but I didnt try it.
`--release-description`
Description of the firmware release, again this can theoretically include HTML but I didn
'
t try it.
`--exe`
Executable file to extract firmware from (e.g.
`dell-thunderbolt-firmware.exe`
)
**REQUIRED**
...
...
data/builder/README.md
View file @
dce91204
...
...
@@ -37,7 +37,7 @@ If, for instance, a plugin needs the old system firmware blob (for a bsdiff)
then the plugin can write to this directory and the startup.sh script will be
able to access it as the chroot-ed
`/boot`
.
Firmware
`.cab`
files using this funtionality should list the
`.tar`
file:
Firmware
`.cab`
files using this fun
c
tionality should list the
`.tar`
file:
<release>
<checksum filename="firmware.tar" target="content"/>
...
...
data/org.freedesktop.fwupd.metainfo.xml
View file @
dce91204
...
...
@@ -291,7 +291,7 @@
<li>
Allow building with older meson
</li>
<li>
Detect the EFI system partition location at runtime
</li>
<li>
Do not use 8bitdo bootloader commands after a successful flash
</li>
<li>
Enable accesing downloaded files in flatpak and snap
</li>
<li>
Enable acces
s
ing downloaded files in flatpak and snap
</li>
<li>
Fix a potential buffer overflow when applying a DFU patch
</li>
<li>
Fix downgrading older releases to devices
</li>
<li>
Fix flashing devices that require a manual replug
</li>
...
...
@@ -405,7 +405,7 @@
<li>
Clarify which devices don't have upgrades
</li>
<li>
Ensure the Thunderbolt version is xx.yy
</li>
<li>
Fix a daemon warning when using fwupdmgr get-results
</li>
<li>
Fix crash
er
with MST flashing
</li>
<li>
Fix crash with MST flashing
</li>
<li>
Fix DFU detach with newer releases of libusb
</li>
<li>
Include the device VID and PID when generating the device-id
</li>
<li>
Set the RemoteId when using GetDetails
</li>
...
...
@@ -553,7 +553,7 @@
<li>
Disable unifying support if no CONFIG_HIDRAW support
</li>
<li>
Do not auto-open all USB devices at startup
</li>
<li>
Do not fail to load the daemon if cached metadata is invalid
</li>
<li>
Do not use system-specific infomation for UEFI PCI devices
</li>
<li>
Do not use system-specific info
r
mation for UEFI PCI devices
</li>
<li>
Fix a crash when using fu_plugin_device_add_delay()
</li>
<li>
Fix the libdfu self test failure on s390 and ppc64
</li>
<li>
Fix various printing issues with the progressbar
</li>
...
...
@@ -648,7 +648,7 @@
<li>
Split up the Unifying HID++2.0 and HID++1.0 functionality
</li>
<li>
Store the metadata files rather than merging to one store
</li>
<li>
Use a longer timeout for some Unifying operations
</li>
<li>
Use the UFY DeviceID prefix for Unifying devi
d
es
</li>
<li>
Use the UFY DeviceID prefix for Unifying devi
c
es
</li>
</ul>
</description>
</release>
...
...
docs/libfwupd/libfwupd-docs.xml
View file @
dce91204
...
...
@@ -155,7 +155,7 @@ fu_plugin_startup (FuPlugin *plugin, GError **error)
</section>
<section>
<title>
Creating an abstact device
</title>
<title>
Creating an abst
r
act device
</title>
<para>
This section shows how you would create a device which is exported
to the daemon and thus can be queried and updated by the client software.
...
...
@@ -294,7 +294,7 @@ fu_plugin_update (FuPlugin *plugin,
For some hardware, we might want to do an action before or after
the actual firmware is squirted into the device.
This could be something as simple as checking the system battery
level is over a certain theshold, or it could be as complicated as
level is over a certain th
r
eshold, or it could be as complicated as
ensuring a vendor-specific GPIO is asserted when specific types
of hardware are updated.
</para>
...
...
@@ -334,7 +334,7 @@ fu_plugin_update_cleanup (FuPlugin *plugin, FuDevice *device, GError **error)
<title>
Detaching to bootloader mode
</title>
<para>
Some hardware can only be updated in a special bootloader mode, which
for most devices can be switched to automaticaly.
for most devices can be switched to automatical
l
y.
In some cases the user to do something manually, for instance
re-inserting the hardware with a secret button pressed.
</para>
...
...
libfwupd/fwupd-client.c
View file @
dce91204
...
...
@@ -651,7 +651,7 @@ fwupd_client_proxy_call_cb (GObject *source, GAsyncResult *res, gpointer user_da
* @error: the #GError, or %NULL
*
* Activates up a device, which normally means the device switches to a new
* firmware verson. This should only be called when data loss cannot occur.
* firmware vers
i
on. This should only be called when data loss cannot occur.
*
* Returns: %TRUE for success
*
...
...
libfwupd/fwupd-enums.h
View file @
dce91204
...
...
@@ -180,7 +180,7 @@ typedef enum {
* FwupdUpdateState:
* @FWUPD_UPDATE_STATE_UNKNOWN: Unknown
* @FWUPD_UPDATE_STATE_PENDING: Update is pending
* @FWUPD_UPDATE_STATE_SUCCESS: Update was successful
l
* @FWUPD_UPDATE_STATE_SUCCESS: Update was successful
* @FWUPD_UPDATE_STATE_FAILED: Update failed
* @FWUPD_UPDATE_STATE_NEEDS_REBOOT: Waiting for a reboot to apply
*
...
...
libfwupd/meson.build
View file @
dce91204
...
...
@@ -122,7 +122,7 @@ if get_option('introspection')
# 2. The map file is required to build the lib that the GIR is built from
#
# To avoid the circular dep, and to ensure we don't change exported API
# accidentaly actually check in a version of the version script to git.
# accidental
l
y actually check in a version of the version script to git.
mapfile_target = custom_target('mapfile',
input: gir[0],
output: 'fwupd.map',
...
...
meson.build
View file @
dce91204
...
...
@@ -48,7 +48,7 @@ lt_revision = '0'
lt_age = '0'
lt_version = '@0@.@1@.@2@'.format(lt_current, lt_age, lt_revision)
# get suported warning flags
# get sup
p
orted warning flags
warning_flags = [
'-fstack-protector-strong',
'-Waggregate-return',
...
...
@@ -77,7 +77,7 @@ warning_flags = [
'-Wmissing-prototypes',
'-Wnested-externs',
'-Wno-cast-function-type',
'-Wno-address-of-packed-member', # incompat
a
ble with g_autoptr()
'-Wno-address-of-packed-member', # incompat
i
ble with g_autoptr()
'-Wno-unknown-pragmas',
'-Wno-discarded-qualifiers',
'-Wno-missing-field-initializers',
...
...
plugins/dell-dock/fu-dell-dock-i2c-mst.c
View file @
dce91204
...
...
@@ -715,7 +715,7 @@ fu_dell_dock_mst_invalidate_bank (FuDevice *symbiote, MSTBank bank_in_use,
new_tag
=
g_bytes_get_data
(
bytes_new
,
NULL
);
g_debug
(
"CRC byte is currently 0x%x"
,
new_tag
[
3
]);
/* tag succesfully cleared */
/* tag succes
s
fully cleared */
if
((
new_tag
[
3
]
==
0xff
&&
crc_tag
[
3
]
!=
0xff
)
||
(
new_tag
[
3
]
==
0x00
&&
crc_tag
[
3
]
==
0xff
))
{
break
;
...
...
plugins/dfu/dfu-common.h
View file @
dce91204
...
...
@@ -115,7 +115,7 @@ typedef enum {
* @DFU_CIPHER_KIND_XTEA: XTEA cipher detected
* @DFU_CIPHER_KIND_RSA: RSA cipher detected
*
* The type of cipher used for transfering the firmware.
* The type of cipher used for transfer
r
ing the firmware.
**/
typedef
enum
{
DFU_CIPHER_KIND_NONE
,
...
...
plugins/dfu/dfu-element.c
View file @
dce91204
...
...
@@ -228,7 +228,7 @@ dfu_element_set_target_size (DfuElement *element, guint32 target_size)
g_assert
(
buf
!=
NULL
);
memcpy
(
buf
,
data
,
length
);
/* set the pading value */
/* set the pad
d
ing value */
if
(
priv
->
padding_value
!=
0x00
)
{
memset
(
buf
+
length
,
priv
->
padding_value
,
...
...
plugins/dfu/dfu-format-metadata.c
View file @
dce91204
...
...
@@ -161,7 +161,7 @@ dfu_firmware_to_metadata (DfuFirmware *firmware, GError **error)
g_set_error
(
error
,
FWUPD_ERROR
,
FWUPD_ERROR_NOT_SUPPORTED
,
"metdata key too long: %s"
,
"met
a
data key too long: %s"
,
key
);
return
NULL
;
}
...
...
plugins/dfu/dfu-self-test.c
View file @
dce91204
...
...
@@ -222,7 +222,7 @@ dfu_firmware_dfu_func (void)
g_assert_cmpint
(
dfu_firmware_get_size
(
firmware
),
==
,
0x8eB4
);
g_assert_cmpint
(
dfu_firmware_get_cipher_kind
(
firmware
),
==
,
DFU_CIPHER_KIND_NONE
);
/* can we roundtrip without lo
o
sing data */
/* can we roundtrip without losing data */
roundtrip_orig
=
dfu_self_test_get_bytes_for_file
(
file
,
&
error
);
g_assert_no_error
(
error
);
g_assert
(
roundtrip_orig
!=
NULL
);
...
...
@@ -263,7 +263,7 @@ dfu_firmware_dfuse_func (void)
g_assert_cmpint
(
dfu_firmware_get_size
(
firmware
),
==
,
0x168d5
);
g_assert_cmpint
(
dfu_firmware_get_cipher_kind
(
firmware
),
==
,
DFU_CIPHER_KIND_NONE
);
/* can we roundtrip without lo
o
sing data */
/* can we roundtrip without losing data */
roundtrip_orig
=
dfu_self_test_get_bytes_for_file
(
file
,
&
error
);
g_assert_no_error
(
error
);
g_assert
(
roundtrip_orig
!=
NULL
);
...
...
@@ -308,7 +308,7 @@ dfu_firmware_metadata_func (void)
g_assert_cmpstr
(
dfu_firmware_get_metadata
(
firmware
,
"key"
),
==
,
"value"
);
g_assert_cmpstr
(
dfu_firmware_get_metadata
(
firmware
,
"???"
),
==
,
NULL
);
/* can we roundtrip without lo
o
sing data */
/* can we roundtrip without losing data */
roundtrip_orig
=
dfu_self_test_get_bytes_for_file
(
file
,
&
error
);
g_assert_no_error
(
error
);
g_assert
(
roundtrip_orig
!=
NULL
);
...
...
plugins/dfu/dfu-target-stm.c
View file @
dce91204
...
...
@@ -117,7 +117,7 @@ dfu_target_stm_upload_element (DfuTarget *target,
g_set_error
(
error
,
FWUPD_ERROR
,
FWUPD_ERROR_NOT_SUPPORTED
,
"memory sector at 0x%04x is not readble"
,
"memory sector at 0x%04x is not read
a
ble"
,
(
guint
)
offset
);
return
NULL
;
}
...
...
plugins/dfu/dfu-target.c
View file @
dce91204
...
...
@@ -1042,7 +1042,7 @@ dfu_target_upload (DfuTarget *target,
if
(
zone_cur
==
zone_last
)
continue
;
/* get the size of the entire continous zone */
/* get the size of the entire contin
u
ous zone */
zone_size
=
dfu_target_get_size_of_zone
(
target
,
zone_cur
);
zone_last
=
zone_cur
;
...
...
plugins/dfu/dfu-target.h
View file @
dce91204
...
...
@@ -30,7 +30,7 @@ G_DECLARE_DERIVABLE_TYPE (DfuTarget, dfu_target, DFU, TARGET, GUsbDevice)
* @DFU_TARGET_TRANSFER_FLAG_ANY_CIPHER: Allow any cipher kinds to be downloaded
* @DFU_TARGET_TRANSFER_FLAG_ADDR_HEURISTIC: Automatically detect the address to use
*
* The optional flags used for transfering firmware.
* The optional flags used for transfer
r
ing firmware.
**/
typedef
enum
{
DFU_TARGET_TRANSFER_FLAG_NONE
=
0
,
...
...
plugins/dfu/dfu-tool.c
View file @
dce91204
...
...
@@ -2156,7 +2156,7 @@ dfu_tool_detach (DfuToolPrivate *priv, gchar **values, GError **error)
if
(
priv
->
transfer_size
>
0
)
dfu_device_set_transfer_size
(
device
,
priv
->
transfer_size
);
/* deta
t
ch */
/* detach */
locker
=
fu_device_locker_new
(
device
,
error
);
if
(
locker
==
NULL
)
return
FALSE
;
...
...
Prev
1
2
Next
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment