1. 30 Apr, 2018 2 commits
  2. 29 Apr, 2018 1 commit
  3. 26 Apr, 2018 1 commit
  4. 23 Apr, 2018 4 commits
    • Mario Limonciello's avatar
      5a256531
    • Mario Limonciello's avatar
      amt: Fix a compilation error on Fedora · f669efcc
      Mario Limonciello authored
      ../plugins/amt/fu-plugin-amt.c: In function ‘mei_context_new’:
      ../plugins/amt/fu-plugin-amt.c:77:2: error: implicit declaration of function ‘memcpy’ [-Werror=implicit-function-declaration]
        memcpy (&ctx->guid, guid, sizeof(*guid));
        ^~~~~~
      ../plugins/amt/fu-plugin-amt.c:77:2: error: incompatible implicit declaration of built-in function ‘memcpy’ [-Werror]
      ../plugins/amt/fu-plugin-amt.c:77:2: note: include ‘<string.h>’ or provide a declaration of ‘memcpy’
      ../plugins/amt/fu-plugin-amt.c:78:2: error: implicit declaration of function ‘memset’ [-Werror=implicit-function-declaration]
        memset (&data, 0, sizeof(data));
        ^~~~~~
      ../plugins/amt/fu-plugin-amt.c:78:2: error: incompatible implicit declaration of built-in function ‘memset’ [-Werror]
      ../plugins/amt/fu-plugin-amt.c:78:2: note: include ‘<string.h>’ or provide a declaration of ‘memset’
      ../plugins/amt/fu-plugin-amt.c: In function ‘mei_recv_msg’:
      ../plugins/amt/fu-plugin-amt.c:117:9: error: implicit declaration of function ‘strerror’; did you mean ‘g_strerror’? [-Werror=implicit-function-declaration]
           rc, strerror(errno));
               ^~~~~~~~
               g_strerror
      ../plugins/amt/fu-plugin-amt.c:117:9: error: nested extern declaration of ‘strerror’ [-Werror=nested-externs]
      ../plugins/amt/fu-plugin-amt.c:116:39: error: format ‘%s’ expects argument of type ‘char *’, but argument 6 has type ‘int’ [-Werror=format=]
               "read failed with status %zd %s",
                                            ~^
                                            %d
           rc, strerror(errno));
               ~~~~~~~~~~~~~~~
      ../plugins/amt/fu-plugin-amt.c: In function ‘mei_send_msg’:
      ../plugins/amt/fu-plugin-amt.c:142:40: error: format ‘%s’ expects argument of type ‘char *’, but argument 6 has type ‘int’ [-Werror=format=]
               "write failed with status %zd %s",
                                             ~^
                                             %d
               written, strerror(errno));
                        ~~~~~~~~~~~~~~~
      ../plugins/amt/fu-plugin-amt.c: In function ‘amt_verify_code_versions’:
      ../plugins/amt/fu-plugin-amt.c:288:14: error: implicit declaration of function ‘strlen’ [-Werror=implicit-function-declaration]
             len != strlen(code_ver->versions[i].version.string))
                    ^~~~~~
      ../plugins/amt/fu-plugin-amt.c:288:14: error: incompatible implicit declaration of built-in function ‘strlen’ [-Werror]
      ../plugins/amt/fu-plugin-amt.c:288:14: note: include ‘<string.h>’ or provide a declaration of ‘strlen’
      ../plugins/amt/fu-plugin-amt.c: In function ‘fu_plugin_amt_create_device’:
      ../plugins/amt/fu-plugin-amt.c:430:2: error: incompatible implicit declaration of built-in function ‘memcpy’ [-Werror]
        memcpy (&ver, response->data, sizeof(struct amt_code_versions));
        ^~~~~~
      ../plugins/amt/fu-plugin-amt.c:430:2: note: include ‘<string.h>’ or provide a declaration of ‘memcpy’
      cc1: all warnings being treated as errors
      f669efcc
    • Mario Limonciello's avatar
      trivial: debian: ignore library-not-linked-against-libc · 8600b644
      Mario Limonciello authored
      lintian is showing false positives.  See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=896012
      for more details.
      8600b644
    • Mario Limonciello's avatar
      Revert "trivial: Compile upower and test plugins with -O0 (Closes: #472)" · df860bbf
      Mario Limonciello authored
      This reverts commit 6b0eb078.
      
      Per debian bug 896012 this is intentional behavior and a problem with
      linitin.  An additional commit will be added to ignore this lintian
      error.
      df860bbf
  5. 20 Apr, 2018 10 commits
  6. 19 Apr, 2018 1 commit
  7. 18 Apr, 2018 5 commits
  8. 17 Apr, 2018 5 commits
    • Mario Limonciello's avatar
      trivial: fix a null pointer dereference · 6b9f07cb
      Mario Limonciello authored
      ../src/fu-main.c: In function ‘fu_main_daemon_method_call’:
      ../src/fu-main.c:667:47: error: null pointer dereference [-Werror=null-dereference]
         polkit_authority_check_authorization (helper->priv->authority, subject,
                                               ~~~~~~^~~~~~
      ../src/fu-main.c:698:47: error: null pointer dereference [-Werror=null-dereference]
         polkit_authority_check_authorization (helper->priv->authority, subject,
                                               ~~~~~~^~~~~~
      6b9f07cb
    • Mario Limonciello's avatar
      trivial: Remove invalid -Wno-cast-function-type · a6f44e11
      Mario Limonciello authored
      Was causing this error on some configurations:
      unrecognized command line option ‘-Wno-cast-function-type
      a6f44e11
    • Mario Limonciello's avatar
      Disable -Wunused-function on clang builds (Closes #467) · a98df55d
      Mario Limonciello authored
      GLib creates two static inline functions for paramaters that may
      not be used that set off warnings in clang but not gcc.
      
      Ignore these on clang builds everywhere that
      G_DEFINE_AUTOPTR_CLEANUP_FUNC is used.
      a98df55d
    • Mario Limonciello's avatar
      trivial: fu-util fix mismanaged memory · 5e13aece
      Mario Limonciello authored
      Caught by clang:
      
      ../src/fu-util.c:473:17: warning: assigning to 'gchar *' (aka 'char *') from 'const gchar *' (aka 'const char *') discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
      	warning_markup = fwupd_remote_get_agreement (remote);
      5e13aece
    • Mario Limonciello's avatar
      trivial: uefi: Remove an unused variable · 7877769c
      Mario Limonciello authored
      Caught by clang:
      
      ../plugins/uefi/fu-plugin-uefi.c:311:32:  warning: unused variable 'iter' [-Wunused-variable]
      	g_autoptr(fwup_resource_iter) iter = NULL;
      7877769c
  9. 16 Apr, 2018 8 commits
  10. 13 Apr, 2018 3 commits